Joscorbe commented on code in PR #2226:
URL: https://github.com/apache/jackrabbit-oak/pull/2226#discussion_r2085387444
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreServiceTest.java:
##########
@@ -155,18 +153,6 @@ public void setUpdateLimit() throws Exception {
assertEquals(17, store.getUpdateLimit());
}
- @Test
- public void keepAlive() throws Exception {
Review Comment:
This test checks for `getMongoClientOptions().isSocketKeepAlive()`, which
doesn't exist at all in modern driver, so this test would have no sense at all.
I marked `keepAlive` and all related properties as deprecated just to help
to detect any uses in any application using Oak as dependency, to avoid
breaking changes, but all those options should be completely removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
