thomasmueller commented on code in PR #2283:
URL: https://github.com/apache/jackrabbit-oak/pull/2283#discussion_r2083944882
##########
oak-run/src/test/resources/org/apache/jackrabbit/oak/index/merge/merge-override-tags-type.json:
##########
@@ -0,0 +1,53 @@
+{
+ "build": {
+ "/oak:index/lucene-2": {
+ "jcr:primaryType": "nam:oak:QueryIndexDefinition",
+ ":version": 2,
+ "tags": ["similarity", "asset", "fragments"],
+ "type": "elasticsearch",
+ "async": "async",
+ "reindex": false,
+ "reindexCount": 1
+ }
+ },
+
+ "run": {
+ "/oak:index/lucene-1": {
+ "jcr:primaryType": "nam:oak:QueryIndexDefinition",
+ ":version": 2,
+ "tags": ["similarity", "asset"],
+ "type": "disabled",
+ "async": "async",
+ "reindex": false,
+ "reindexCount": 1
+ },
+ "/oak:index/lucene-1-custom-1": {
+ "jcr:primaryType": "nam:oak:QueryIndexDefinition",
+ ":version": 2,
+ "tags": "custom",
+ "type": "lucene",
+ "async": "async",
+ "reindex": false,
+ "reindexCount": 1
+ }
+ },
+
+ "expected": {
+ "/oak:index/lucene-2": {
+ "jcr:primaryType": "nam:oak:QueryIndexDefinition",
+ ":version": 2,
+ "tags": ["similarity", "asset", "fragments"],
+ "type": "elasticsearch",
+ "async": "async",
+ "reindex": false,
+ "reindexCount": 1
+ },
+ "/oak:index/lucene-2-custom-1": {
+ "jcr:primaryType": "nam:oak:QueryIndexDefinition",
+ "tags": ["asset", "custom", "fragments"],
Review Comment:
You are right, this is incorrect... actually it should be:
* lucene-1: `"tags": ["asset", "custom", "fragments", "similarity"]`
Basically, the customer should not be able to remove a tag.
I will fix this and add more unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
