rishabhdaim commented on code in PR #2222:
URL: https://github.com/apache/jackrabbit-oak/pull/2222#discussion_r2039094080
##########
oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/CugAccessControlManager.java:
##########
@@ -252,7 +252,7 @@ public AccessControlPolicy[] getEffectivePolicies(@NotNull
Set<Principal> princi
return Collections.emptyIterator();
}
if (absPaths == null || absPaths.length == 0) {
- return Iterators.forArray(getEffectivePolicies(principals));
+ return Arrays.asList(getEffectivePolicies(principals)).iterator();
Review Comment:
> In this case, the iterator was obtained after converting an array to a
list and then to an Iterator. If this was performance critical, that wouldn't
have been done like that, right?
I am sorry, I didn't understand your concern here.
`getEffectivePolicies(principals)` returns an array and `Iterators.forArray`
provide an iterator over this array. I couldn't see any conversion to list
happening in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
