fabriziofortino commented on PR #2180: URL: https://github.com/apache/jackrabbit-oak/pull/2180#issuecomment-2724779520
@nfsantos > Could we log a warning if we find a fuzzy query with the old format? Maybe the log could be throttled, printed only once per run or only once every x times. This could help in migrating to the new fuzzy format. I added a log.trace call when this conversion happens. I don't think it would be correct to have a warning here because, so far, there is no plan of deprecating/migrating lucene in favour of elasticsearch or a more recent version of lucene. Queries executed against an Elastic index have to be backward compatible with Lucene queries based on version 4.x but not the other way around. A query with `roam~2` would work on Elastic only. We cannot change Lucene to be forward compatible with more recent versions. > > I think the PR is missing some tests (or do we already have these tests?) > > * The `~` character appears in the query but not as part of a fuzzy match. > * The query contains several fuzzy match expressions. > * The query contains a mix of old and new style fuzzy matches. I added all these cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
