amit-jain commented on code in PR #2137:
URL: https://github.com/apache/jackrabbit-oak/pull/2137#discussion_r1986913793
##########
oak-blob-cloud-azure/src/main/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzureBlobStoreBackend.java:
##########
@@ -1264,34 +1132,41 @@ private boolean loadItems() {
try {
currentThread().setContextClassLoader(getClass().getClassLoader());
- CloudBlobContainer container =
azureBlobContainerProvider.getBlobContainer();
- if (!firstCall && (resultContinuation == null ||
!resultContinuation.hasContinuation())) {
- LOG.trace("No more records in container.
containerName={}", container);
+ if (!hasMorePages) {
+ LOG.trace("No more records in container.
containerName={}", containerClient.getBlobContainerName());
return false;
}
- firstCall = false;
- ResultSegment<ListBlobItem> results =
container.listBlobsSegmented(null, false,
EnumSet.noneOf(BlobListingDetails.class), null, resultContinuation, null, null);
- resultContinuation = results.getContinuationToken();
- for (ListBlobItem item : results.getResults()) {
- if (item instanceof CloudBlob) {
-
items.add(AzureBlobInfo.fromCloudBlob((CloudBlob)item));
- }
+
Review Comment:
Consider just using the sdk without any decorator as well. Just returning
blobItems.getIterator() directly in the getAll* methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
