thomasmueller commented on code in PR #2136: URL: https://github.com/apache/jackrabbit-oak/pull/2136#discussion_r1980833553
########## oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/MarkSweepGarbageCollector.java: ########## @@ -380,7 +375,13 @@ protected void markAndSweep(boolean markOnly, boolean forceBlobRetrieve) throws } finally { statsCollector.updateDuration(sw.elapsed(TimeUnit.MILLISECONDS), TimeUnit.MILLISECONDS); if (!LOG.isTraceEnabled() && !traceOutput) { - Closeables.close(fs, threw); + try { + fs.close(); Review Comment: This can throw a NullPointerException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org