daniancu commented on PR #2038: URL: https://github.com/apache/jackrabbit-oak/pull/2038#issuecomment-2694595120
> Also, I think the place to adding `getBinCollection()` is wrong. We should have this in `DocumentStore` interface with default implementation of `noBin` and then override this for `MongoDocumentStore` only. > > For reference we could use `default Throttler throttler()`. > > For test we could override this for `MemoryDocumentStore` too. > > cc @Joscorbe @stefan-egli we discussed about adding a `hidden` collection in [JIra](https://issues.apache.org/jira/browse/OAK-11444?focusedCommentId=17929671&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17929671) The idea was to avoid exposing it to other implementations because we only need it for Mongo one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
