nfsantos commented on code in PR #2108:
URL: https://github.com/apache/jackrabbit-oak/pull/2108#discussion_r1975173350
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/IndexDefinition.java:
##########
@@ -887,31 +884,36 @@ public IndexingRule getApplicableIndexingRule(String
primaryNodeType) {
public IndexingRule getApplicableIndexingRule(NodeState state) {
//This method would be invoked for every node. So be as
//conservative as possible in object creation
- List<IndexingRule> rules = null;
- List<IndexingRule> r = indexRules.get(getPrimaryTypeName(state));
- if (r != null) {
- rules = new ArrayList<>(r);
+ {
+ List<IndexingRule> rules =
indexRules.get(getPrimaryTypeName(state));
+ IndexingRule rule = getApplicableIndexingRule(state, rules);
+ if (rule != null) {
+ return rule;
+ }
}
for (String name : getMixinTypeNames(state)) {
- r = indexRules.get(name);
- if (r != null) {
- if (rules == null) {
- rules = new ArrayList<>();
- }
- rules.addAll(r);
+ List<IndexingRule> rules = indexRules.get(name);
+ IndexingRule rule = getApplicableIndexingRule(state, rules);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
