nfsantos commented on code in PR #2118:
URL: https://github.com/apache/jackrabbit-oak/pull/2118#discussion_r1971071362
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/IndexImporterSupportBase.java:
##########
@@ -40,15 +40,17 @@ public IndexImporterSupportBase(IndexHelper indexHelper) {
}
public void importIndex(File importDir) throws IOException,
CommitFailedException {
- IndexImporter importer = new IndexImporter(
- nodeStore,
- importDir,
- createIndexEditorProvider(),
- createLock(),
- indexHelper.getStatisticsProvider(),
- indexHelper.getIndexReporter());
- addImportProviders(importer);
- importer.importIndex();
+ try (IndexEditorProvider providers = createIndexEditorProvider()) {
Review Comment:
Yes, I'm piggybacking this, a previous PR was missing a call to `close()`
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
