rishabhdaim commented on code in PR #2039:
URL: https://github.com/apache/jackrabbit-oak/pull/2039#discussion_r1936849986
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/datastore/DataStoreTextWriter.java:
##########
@@ -131,7 +130,7 @@ public void write(@NotNull String blobId,@NotNull String
text) throws IOExceptio
File textFile = getFile(stripLength(blobId));
ensureParentExists(textFile);
//TODO should we compress
- Files.write(text, textFile, StandardCharsets.UTF_8);
+ org.apache.jackrabbit.guava.common.io.Files.write(text, textFile,
StandardCharsets.UTF_8);
Review Comment:
shouldn't this be removed ?
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/datastore/DataStoreTextWriter.java:
##########
@@ -233,7 +232,7 @@ public String toString() {
private Set<String> loadFromFile(File file) throws IOException {
Set<String> result = new HashSet<>();
if (file.exists()) {
- result.addAll(Files.readLines(file, StandardCharsets.UTF_8));
+
result.addAll(org.apache.jackrabbit.guava.common.io.Files.readLines(file,
StandardCharsets.UTF_8));
Review Comment:
same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
