reschke commented on code in PR #2005:
URL: https://github.com/apache/jackrabbit-oak/pull/2005#discussion_r1933434747
##########
oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProviderWithCacheTest.java:
##########
@@ -169,42 +168,4 @@ public void testGetGroupMembershipExternalUserAndLocal()
throws Exception {
Set<Principal> readFromCache =
principalProvider.getMembershipPrincipals(user.getPrincipal());
assertEquals(expected, readFromCache);
}
-
-// @Test
Review Comment:
While I don't understand why we have a commented-out test case, wouldn't it
be better to leave it in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
