reschke commented on code in PR #1678:
URL: https://github.com/apache/jackrabbit-oak/pull/1678#discussion_r1745169800
##########
oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandlerTest.java:
##########
@@ -245,7 +245,8 @@ public void testListIdentitiesAfterSync() throws Exception {
sync(USER_ID, false);
// membership-nesting is 1 => expect only 'USER_ID' plus the declared
group-membership
- Set<String> expected = Sets.newHashSet(USER_ID);
+ Set<String> expected = new HashSet<>();
Review Comment:
maybe:
Set<String> expected = Stream.of(USER_ID).collect(Collectors.toSet());
?
##########
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/SharedDataStoreUtilsTest.java:
##########
@@ -518,12 +524,13 @@ public void testStreamFromGetAllRecords() throws
Exception {
File rootFolder = folder.newFolder();
dataStore = getBlobStore(rootFolder);
int number = 10;
- Set<DataRecord> added = newHashSet();
+ Set<DataRecord> added = new HashSet<>();
for (int i = 0; i < number; i++) {
added.add(dataStore.addRecord(randomStream(i, 16516)));
}
- Set<DataRecord> retrieved = newHashSet((dataStore.getAllRecords()));
+ Set<DataRecord> retrieved = new HashSet<>();
Review Comment:
dito
##########
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/SharedDataStoreUtilsTest.java:
##########
@@ -471,15 +471,18 @@ public void testGetAllRecords() throws Exception {
File rootFolder = folder.newFolder();
dataStore = getBlobStore(rootFolder);
int number = 10;
- Set<String> added = newHashSet();
+ Set<String> added = new HashSet<>();
for (int i = 0; i < number; i++) {
String rec = dataStore.addRecord(randomStream(i, 16516))
.getIdentifier().toString();
added.add(rec);
}
- Set<String> retrieved =
newHashSet(Iterables.transform(newHashSet(dataStore.getAllRecords()),
- input -> input.getIdentifier().toString()));
+ Set<DataRecord> recordSet = new HashSet<>();
Review Comment:
Maybe
CollectionUtils.toSet(...)
?
##########
oak-blob-plugins/src/test/java/org/apache/jackrabbit/oak/plugins/blob/SharedDataStoreUtilsTest.java:
##########
@@ -508,8 +511,11 @@ public void testGetAllRecordsWithMeta() throws Exception {
added.add(rec);
}
- Set<String> retrieved =
newHashSet(Iterables.transform(newHashSet(dataStore.getAllRecords()),
- input -> input.getIdentifier().toString()));
+ Set<DataRecord> recordSet = new HashSet<>();
Review Comment:
dito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
