nfsantos commented on code in PR #1621:
URL: https://github.com/apache/jackrabbit-oak/pull/1621#discussion_r1703893809
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##########
@@ -350,15 +352,29 @@ public void reindex() throws CommitFailedException,
IOException {
INDEXING_PHASE_LOGGER.info("[TASK:INDEXING:START] Starting
indexing");
Stopwatch indexerWatch = Stopwatch.createStarted();
try {
-
if (flatFileStores.size() > 1) {
indexParallel(flatFileStores, indexer, progressReporter);
} else if (flatFileStores.size() == 1) {
FlatFileStore flatFileStore = flatFileStores.get(0);
+ TopKSlowestPaths slowestTopKElements = new
TopKSlowestPaths(TOP_SLOWEST_PATHS_TO_LOG);
Review Comment:
It seems to me that adapting `IndexingProgressReporter` to expose this
information would require some refactoring. I'd rather keep this simple and
orthogonal to existing mechanisms, at least until being more sure of the value
of logging the slowest elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
