nfsantos commented on PR #1597: URL: https://github.com/apache/jackrabbit-oak/pull/1597#issuecomment-2247179490
> So that's a new method, right? Not quite. This method is to replace an internal implementation here: https://github.com/apache/jackrabbit-oak/blob/2ef302327e5eb0b19c273a7a794e7008a5ba4fcb/oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/ChildNodeStateProvider.java#L127-L129 But it would be a new method in the public API. > Shouldn't this be called "isParent" or "isParentOf"? I chose `isDirectAncestor` to be aligned with the existing method `isAncestor`. But I'm open to using a different name. > Where would it be used? See the link above, it would replace the internal method in ChildNodeStateProvider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
