On 04.07.17 11:15, Francesco Mari wrote:
2017-07-04 10:52 GMT+02:00 Andrei Dulceanu <[email protected]>:
Now my question is this: do we have a simple percentile implementation in
Oak (I didn't find one)?
I'm not aware of a percentile implementation in Oak.
If not, would you recommend writing my own or adapting/extracting an
existing one in a utility class?
In the past we copied and pasted source code from other projects in
Oak. As long as the license allows it and proper attribution is given,
it shouldn't be a problem. That said, I'm not a big fan of either
rewriting an implementation from scratch or copying and pasting source
code from other projects. Is exposing a percentile really necessary?
If yes, how big of a problem is embedding of commons-math3?
We should avoid copy paste as we might miss important fixes in later
releases. I only did this once for some code where we needed a fix that
wasn't yet released. It was a hassle.
I would just add a dependency to commons-math3. Its a library exposing
the functionality we require, so let's use it.
Michael
