Hi

I have the impression this is not a good idea, unless you cleanse the classes.

E.g. the AbstractTree has protected mutable fields (bad practice per se, if 
exported even worse)

Or TreeConstants exposing an „internal“ constant (should be a final class not 
an interface, actually)

Or ChildOrderDiff which operates on a hidden field (and thus should not be 
exposed, I would assume)

Unfortunately ImmutableTree extends AbstractTree so exporting the former 
requires exporting the latter …

From the outside, I have not the best of all gut feelings here...

Regards
Felix

> Am 14.11.2014 um 07:53 schrieb Chetan Mehrotra <[email protected]>:
> 
> Hi Team,
> 
> For OAK-2261 I need to use ImmutableTree from
> org.apache.jackrabbit.oak.plugins.tree package which is currently not
> exported by Oak core. To proceed further I would like to export this
> package as part of OAK-2269
> 
> Unless someone objects I would make the change by EOD today
> 
> Chetan Mehrotra

Reply via email to