I did a write-up on it on the train home: https://theartandscienceofruby.com/test-driven-development-kata-9/ (plus a quick tidy up of the final code - I'm pretty pleased with how it turned out).
B On Friday, 22 November 2024 at 09:53:00 UTC Darren Jones wrote: > Really loved the session last night, be good to do something similar again > (or even a longer coding session on a weekend?) Thanks to Rob for running > it! > > This is where me and Ste got up to: > > > All the tests were passing, but we weren't happy with so much logic being > in the scan method. Our next move was to move most of that logic out of the > scan method, use the total method more and probably create some more > methods. > > We also weren't completely happy with how the pricing rules were presented > and would probably think a bit more about that. The seemed to be described > in a deliberately vague way in the kata, so getting the description right > for those would help, especially to cover different types of offers. > > The next consideration was whether or not to cache more info in the cart. > Currently it just keeps track of which items have been added and in what > order, but we considered keeping a running total and sub-totals for each > item as well. > > Be interesting to see what everyone else came up with! > > DAZ > ps - Ste recommended this talk by Sandi Metz about refactoring the Gilded > Rose Kata > https://www.youtube.com/watch?v=8bZh5LMaSmE > -- You received this message because you are subscribed to the Google Groups "North West Ruby User Group (NWRUG)" group. To unsubscribe from this group and stop receiving emails from it, send an email to nwrug-members+unsubscr...@googlegroups.com. To view this discussion, visit https://groups.google.com/d/msgid/nwrug-members/a4e87f6a-ef1e-48f0-955b-5c2318763fafn%40googlegroups.com.
