On Thu, Jul 24, 2025 at 10:00:45PM +0000, marc.herb...@linux.intel.com wrote: > From: Marc Herbert <marc.herb...@linux.intel.com> > > move err() function at the top so we can fail early. err() does not have > any dependency so it can be first. > > Signed-off-by: Marc Herbert <marc.herb...@linux.intel.com>
Thanks! Applied to https://github.com/pmem/ndctl/commits/pending/ with [alison: edit commit message and log] > --- > test/common | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) > > diff --git a/test/common b/test/common > index 2d8422f26436..2d076402ef7c 100644 > --- a/test/common > +++ b/test/common > @@ -1,6 +1,20 @@ > # SPDX-License-Identifier: GPL-2.0 > # Copyright (C) 2018, FUJITSU LIMITED. All rights reserved. > > +# err > +# $1: line number which error detected > +# $2: cleanup function (optional) > +# > + > +test_basename=$(basename "$0") > + > +err() > +{ > + echo test/"$test_basename": failed at line "$1" > + [ -n "$2" ] && "$2" > + exit "$rc" > +} > + > # Global variables > > # NDCTL > @@ -53,17 +67,6 @@ E820_BUS="e820" > > # Functions > > -# err > -# $1: line number which error detected > -# $2: cleanup function (optional) > -# > -err() > -{ > - echo test/$(basename $0): failed at line $1 > - [ -n "$2" ] && "$2" > - exit $rc > -} > - > reset() > { > $NDCTL disable-region -b $NFIT_TEST_BUS0 all > -- > 2.50.1 >
