On 6/18/25 3:21 PM, Dan Williams wrote:
> There are a few instances of the warning:
>
> "meson.build: WARNING: Project does not target a minimum version but
> uses feature deprecated since '0.56.0': dependency.get_pkgconfig_variable.
> use dependency.get_variable(pkgconfig : ...) instead"
>
> Move to the new style and mark the project as needing at least that minimum
> version.
>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
Reviewed-by: Dave Jiang <dave.ji...@intel.com>
> ---
> contrib/meson.build | 2 +-
> meson.build | 5 +++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/meson.build b/contrib/meson.build
> index 48aa7c071f92..33a409a2d7d0 100644
> --- a/contrib/meson.build
> +++ b/contrib/meson.build
> @@ -2,7 +2,7 @@ bashcompletiondir = get_option('bashcompletiondir')
> if bashcompletiondir == ''
> bash_completion = dependency('bash-completion', required : false)
> if bash_completion.found()
> - bashcompletiondir =
> bash_completion.get_pkgconfig_variable('completionsdir')
> + bashcompletiondir = bash_completion.get_variable(pkgconfig :
> 'completionsdir')
> else
> bashcompletiondir = datadir / 'bash-completion/completions'
> endif
> diff --git a/meson.build b/meson.build
> index 19808bb21db8..300eddb99235 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1,5 +1,6 @@
> project('ndctl', 'c',
> version : '82',
> + meson_version: '>= 0.56.0',
> license : [
> 'GPL-2.0',
> 'LGPL-2.1',
> @@ -159,9 +160,9 @@ endif
>
> if get_option('systemd').enabled()
> systemd = dependency('systemd', required : true)
> - systemdunitdir = systemd.get_pkgconfig_variable('systemdsystemunitdir')
> + systemdunitdir = systemd.get_variable(pkgconfig : 'systemdsystemunitdir')
> udev = dependency('udev', required : true)
> - udevdir = udev.get_pkgconfig_variable('udevdir')
> + udevdir = udev.get_variable(pkgconfig : 'udevdir')
> udevrulesdir = udevdir / 'rules.d'
> endif
>
