On Wed, May 07, 2025 at 04:15:15PM +0000, marc.herb...@linux.intel.com wrote: > From: Marc Herbert <marc.herb...@linux.intel.com> > > This fixes the ability to copy and paste the helpful meson output when a > test fails, in order to re-run a failing test directly outside meson and > from any current directory. > > meson never had that problem because it always switches to a constant > directory before running the tests. > > Fixes commit ef85ab79e7a4 ("cxl/test: Add topology enumeration and > hotplug test") which added the (failing) search for the cxl binary. > > Signed-off-by: Marc Herbert <marc.herb...@linux.intel.com> > ---
Thanks for the patch and welcome to ndctl ! (where you get 3 replies to your first patch in less than a day :)) Please update and send a v2. Then there will be no [as: updated commit msg and log] polluting the final commit. Prefer commit msg: test: set the $CXL environment variable in meson.build Thanks! Alison > test/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/meson.build b/test/meson.build > index d871e28e17ce..2fd7df5211dd 100644 > --- a/test/meson.build > +++ b/test/meson.build > @@ -255,6 +255,7 @@ foreach t : tests > env : [ > 'NDCTL=@0@'.format(ndctl_tool.full_path()), > 'DAXCTL=@0@'.format(daxctl_tool.full_path()), > + 'CXL=@0@'.format(cxl_tool.full_path()), > 'TEST_PATH=@0@'.format(meson.current_build_dir()), > 'DATA_PATH=@0@'.format(meson.current_source_dir()), > ], > -- > 2.49.0 > >