Re: [PATCH] [ndctl PATCH v2] ndctl/list: display region caps for any of BTT, PFN, DAX

[Donet Tom]

On 2/27/25 01:13, Alison Schofield wrote:

On Wed, Feb 26, 2025 at 11:32:30AM +0530, Donet Tom wrote:

On 2/20/25 19:05, Jeff Moyer wrote:

diff --git a/ndctl/json.c b/ndctl/json.c
index 23bad7f..7646882 100644
--- a/ndctl/json.c
+++ b/ndctl/json.c
@@ -381,7 +381,7 @@ struct json_object *util_region_capabilities_to_json(struct 
ndctl_region *region
        struct ndctl_pfn *pfn = ndctl_region_get_pfn_seed(region);
        struct ndctl_dax *dax = ndctl_region_get_dax_seed(region);
-       if (!btt || !pfn || !dax)
+       if (!btt && !pfn && !dax)
                return NULL;
        jcaps = json_object_new_array();

Reviewed-by: Jeff Moyer <jmo...@redhat.com>

Thanks Jeff


Hi Alison

Should I send a v3 with Reviewed-by tag or will you take the patch with the
tag?

No need. The tags with gather automagically upon applying.
I'll also rm the text meant for below the --- like Zhijian noted.

Thank you.

Thanks for the patch!

Thanks
Donet