alison.schofield@ wrote:
> From: Alison Schofield <alison.schofi...@intel.com>
>
> cxl list users may discover the firmware revision of a memory
> device by using the -F option to cxl list. That option uses
> the CXL GET_FW_INFO command and emits this json:
>
> "firmware":{
> "num_slots":2,
> "active_slot":1,
> "staged_slot":1,
> "online_activate_capable":false,
> "slot_1_version":"BWFW VERSION 0",
> "fw_update_in_progress":false
> }
>
> Since device support for GET_FW_INFO is optional, the above method
> is not guaranteed. However, the IDENTIFY command is mandatory and
> provides the current firmware revision.
>
> Accessors already exist for retrieval from sysfs so simply add
> the new json member to the default memdev listing.
>
> This means users of the -F option will get the same info twice if
> GET_FW_INFO is supported.
>
> [
> {
> "memdev":"mem9",
> "pmem_size":268435456,
> "serial":0,
> "host":"0000:c0:00.0"
> "firmware_version":"BWFW VERSION 00",
> }
> ]
>
> Suggested-by: Dan Williams <dan.j.willi...@intel.com>
> Signed-off-by: Alison Schofield <alison.schofi...@intel.com>
Looks good to me:
Reviewed-by: Dan Williams <dan.j.willi...@intel.com>
