On Mon, Apr 29, 2024 at 12:04:24PM -0500, John Groves wrote:
> + case S_IFREG:
> + inode->i_op = NULL /* famfs_file_inode_operations */;
> + inode->i_fop = NULL /* &famfs_file_operations */;
Don't. We should never, ever store NULL in either.
inode->i_op = &empty_iops;
inode->i_fop = &no_open_fops;
in inode_init_always() is there precisely to avoid doing that.
IOW, the right thing would be something along the lines of
/* inode->i_op = famfs_file_inode_operations */;
if you want a placeholder for a patch later in the series - or
simply /* methods will be set here in a commit or two */
