> -----Original Message-----
> From: Kandpal, Suraj
> Sent: Wednesday, June 25, 2025 4:50 PM
> To: Jani Nikula <jani.nik...@linux.intel.com>; intel...@lists.freedesktop.org;
> intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org;
> nouveau@lists.freedesktop.org; Lyude Paul <ly...@redhat.com>
> Cc: Murthy, Arun R <arun.r.mur...@intel.com>
> Subject: RE: [PATCH 00/13] Modify drm helpers to use luminance
>
>
>
> > -----Original Message-----
> > From: Jani Nikula <jani.nik...@linux.intel.com>
> > Sent: Wednesday, June 25, 2025 2:33 PM
> > To: Kandpal, Suraj <suraj.kand...@intel.com>;
> > intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org;
> > dri-de...@lists.freedesktop.org; nouveau@lists.freedesktop.org; Lyude
> > Paul <ly...@redhat.com>
> > Cc: Murthy, Arun R <arun.r.mur...@intel.com>; Kandpal, Suraj
> > <suraj.kand...@intel.com>
> > Subject: Re: [PATCH 00/13] Modify drm helpers to use luminance
> >
> > On Fri, 20 Jun 2025, Suraj Kandpal <suraj.kand...@intel.com> wrote:
> > > This series modifies drm dp edp helpers so that drivers can now use
> > > them to manipulate brightness using luminance value via the
> > > PANEL_TARGET_LUMINANCE_VALUE register. This feature was introduced
> > > frin eDP 1.5.
> > >
> > > Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> > >
> > > Suraj Kandpal (13):
> > > drm/dp: Introduce new member in drm_backlight_info
> > > drm/dp: Add argument in drm_edp_backlight_init
> > > drm/dp: Add argument for max luminance in drm_edp_backlight_init
> > > drm/dp: Move from u16 to u32 for max in drm_edp_backlight_info
> > > drm/dp: Change current_level argument type to u32
> > > drm/dp: Modify drm_edp_probe_state
> > > drm/dp: Change argument type for drm_edp_backlight_set_level
> > > drm/dp: Modify drm_edp_backlight_set_level
> > > drm/dp: Change argument type of drm_edp_backlight_enable
> > > drm/dp: Enable backlight control using luminance
> > > drm/i915/backlight: Use drm helper to initialize edp backlight
> > > drm/i915/backlight: Use drm helper to set edp backlight
> > > drm/i915/backlight: Use drm_edp_backlight_enable
> >
> > Acked-by: Jani Nikula <jani.nik...@intel.com>
> >
> > for merging the last three patches via drm-misc.
> >
> > However, would be great to solicit feedback on the series from
> > non-Intel folks too. Cc: Lyude who's worked on DPCD brightness before.
>
> Sure will wait and see if we have any more comments on this till Friday before
> merging this.
>
No comments here will be merging this today
> Regards,
> Suraj Kandpal
>
> >
> > BR,
> > Jani.
> >
> > >
> > > drivers/gpu/drm/display/drm_dp_helper.c | 92 ++++++++----
> > > .../drm/i915/display/intel_dp_aux_backlight.c | 140 ++++++------------
> > > drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +-
> > > drivers/gpu/drm/nouveau/nouveau_backlight.c | 7 +-
> > > include/drm/display/drm_dp_helper.h | 10 +-
> > > 5 files changed, 127 insertions(+), 124 deletions(-)
> >
> > --
> > Jani Nikula, Intel