commit ebb945a94bba ("drm/nouveau: port all engines to new engine module
format") introduced a TODO to nouveau_chan.h, stating that an
unspecified rework would take place in the "near future".

This seems to mean the variable 'accel_done' below which is never read
and, therefore, must be a relict forgotten in a previous cleanup.

Remove the TODO and accel_done.

Signed-off-by: Philipp Stanner <pha...@kernel.org>
---
Changes in v2:
  - Remove accel_done, too. (Danilo)
---
 drivers/gpu/drm/nouveau/nouveau_chan.h | 2 --
 drivers/gpu/drm/nouveau/nouveau_dma.h  | 1 -
 2 files changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.h 
b/drivers/gpu/drm/nouveau/nouveau_chan.h
index 016f668c0bc1..7133e4a03504 100644
--- a/drivers/gpu/drm/nouveau/nouveau_chan.h
+++ b/drivers/gpu/drm/nouveau/nouveau_chan.h
@@ -33,8 +33,6 @@ struct nouveau_channel {
                u64 addr;
        } push;
 
-       /* TODO: this will be reworked in the near future */
-       bool accel_done;
        void *fence;
        struct {
                int max;
diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.h 
b/drivers/gpu/drm/nouveau/nouveau_dma.h
index c52cda82353e..790045ff5fff 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dma.h
+++ b/drivers/gpu/drm/nouveau/nouveau_dma.h
@@ -92,7 +92,6 @@ FIRE_RING(struct nouveau_channel *chan)
 {
        if (chan->dma.cur == chan->dma.put)
                return;
-       chan->accel_done = true;
 
        if (chan->dma.ib_max) {
                nv50_dma_push(chan, chan->push.addr + (chan->dma.put << 2),
-- 
2.48.1

Reply via email to