On Fri, 2024-11-22 at 04:57 -0800, Zhi Wang wrote:
> +static int
> +ad102_execute_scrubber(struct nvkm_gsp *gsp)
> +{
> + struct nvkm_falcon_fw fw = {0};
> + struct nvkm_subdev *subdev = &gsp->subdev;
> + struct nvkm_device *device = subdev->device;
> + int ret;
> +
> + if (!gsp->fws.scrubber || is_scrubber_completed(gsp))
> + return 0;Shouldn't it be a bug if fws.scrubber is not defined? If we need the scrubber and it doesn't exist, then I don't think it should silently fail.
