On 29/9/24 22:30, Yonatan Maman wrote:
From: Yonatan Maman <yma...@nvidia.com>
This patch series addresses two critical issues in the Nouveau driver related
to device channels, error handling and memory leaking.
- Memory Leak in migrate_to_ram - the migrate_to_ram function was identified as
leaking memory when a copy push command fails. This results in the function
returning a dirty HIGH_USER page, which can expose sensitive information and
pose a security risk. To mitigate this vulnerability, the patch ensures that a
zero page is allocated for the destination page, thereby preventing memory
leaks and enhancing the security of the driver in case of failure.
- Privileged Error in Copy Engine Channel - an error was observed when the
nouveau_dmem_copy_one function is executed, leading to a Host Copy Engine
Privileged error on channel 1. The patch addresses this by adjusting the Copy
Engine channel configuration to permit privileged push commands, thus resolving
the error.
Hi Yonatan,
Thanks for these!
For the series: Reviewed-by: Ben Skeggs <bske...@nvidia.com>
Ben.
Yonatan Maman (2):
nouveau/dmem: Fix privileged error in copy engine channel
nouveau/dmem: Fix memory leak in `migrate_to_ram` upon copy error
drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
