Re: [PATCH 04/10] iommu: Mark dev_iommu_get() with lockdep

[Moritz Fischer]

On Tue, Nov 28, 2023 at 08:48:00PM -0400, Jason Gunthorpe wrote:

Allocation of dev->iommu must be done under the
iommu_probe_device_lock. Mark this with lockdep to discourage future
mistakes.

Reviewed-by: Jerry Snitselaar <jsnit...@redhat.com>
Tested-by: Hector Martin <mar...@marcan.st>
Signed-off-by: Jason Gunthorpe <j...@nvidia.com>
---
  drivers/iommu/iommu.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 0d25468d53a68a..4323b6276e977f 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c

@@ -334,6 +334,8 @@ static struct dev_iommu *dev_iommu_get(struct device *dev)

  {
        struct dev_iommu *param = dev->iommu;

+       lockdep_assert_held(&iommu_probe_device_lock);
+
        if (param)
                return param;

--
2.42.0

Reviewed-by: Moritz Fischer <mori...@google.com>

Cheers,
Moritz