On Sun, May 23, 2021 at 7:32 AM David Bremner <[email protected]> wrote: > > Felipe Contreras <[email protected]> writes: > > > We don't need to check for the order here, that is done in another test. > > > > Signed-off-by: Felipe Contreras <[email protected]> > > --- > > test/T395-ruby.sh | 12 ++++-------- > > 1 file changed, 4 insertions(+), 8 deletions(-) > > > > diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh > > index e828efed..9298bc9e 100755 > > --- a/test/T395-ruby.sh > > +++ b/test/T395-ruby.sh > > @@ -20,21 +20,17 @@ test_ruby() { > > } > > > > test_begin_subtest "compare thread ids" > > -notmuch search --sort=oldest-first --output=threads tag:inbox > EXPECTED > > +notmuch search --output=threads tag:inbox > EXPECTED > > test_ruby <<"EOF" > > -q = db.query('tag:inbox') > > -q.sort = Notmuch::SORT_OLDEST_FIRST > > -q.search_threads.each do |t| > > +db.query('tag:inbox').search_threads.each do |t| > > puts 'thread:%s' % t.thread_id > > end > > EOF > > > > Is this assuming that the sort order in the CLI is the same as in the > library / bindings? that seems a bit fragile if so.
Both the CLI and the bindings are using the same libnotmuch library. If neither of them specify a sort order, the default sort order of libnotmuch would be used (I presume). Exactly the same order I would get if I write a C program that uses libnotmuch and doesn't specify any order. Why would the CLI specify an order the user didn't specify to libnotmuch? -- Felipe Contreras _______________________________________________ notmuch mailing list -- [email protected] To unsubscribe send an email to [email protected]
