Hi Dmitry. On Sun, 29 Jan 2012 02:48, Dmitry Kurochkin <[email protected]> wrote: > I only meant trailing whitespaces in test/emacs file in the lines added > by the patch. Trailing whitespaces in expected results are obviously > fine.
Ah, okay. I fixed those with delete-trailing-whitespace, but then noticed that this also corrected some trailing whitespace in unrelated tests, reverted that and then forgot about the trailing whitespace in my tests by the time I responded. > I think splitting emacs tests based on -hello, -show and -search views > is a good idea. Splitting existing tests is out of scope of this > patch. But I think it may be a good opportunity to add a new file with > -hello tests. You're right; I'll do that if you find other flaws in your next review. Otherwise, I'll just put it in another patch. Cheers, Daniel
pgp03dGO6zeUm.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
