JackieTien97 commented on code in PR #539:
URL: https://github.com/apache/tsfile/pull/539#discussion_r2209780435
##########
java/tsfile/src/main/java/org/apache/tsfile/read/filter/operator/ExtractTimeFilterOperators.java:
##########
@@ -368,22 +387,28 @@ public boolean timeSatisfy(long time) {
@Override
public boolean satisfyStartEndTime(long startTime, long endTime) {
- boolean lt =
- !(truncatedEqualsFunction.apply(startTime, endTime)
- && evaluateFunction.apply(startTime) >= constant
- && evaluateFunction.apply(endTime) >= constant);
- boolean gt =
- !(truncatedEqualsFunction.apply(startTime, endTime)
- && evaluateFunction.apply(startTime) <= constant
- && evaluateFunction.apply(endTime) <= constant);
- return lt || gt;
+ return !(truncatedEqualsFunction.apply(startTime, endTime)
+ && evaluateFunction.apply(startTime) == constant
+ && evaluateFunction.apply(endTime) == constant);
}
@Override
public boolean containStartEndTime(long startTime, long endTime) {
- return !(truncatedEqualsFunction.apply(startTime, endTime)
- && evaluateFunction.apply(startTime) == constant
- && evaluateFunction.apply(endTime) == constant);
+ return truncatedEqualsFunction.apply(startTime, endTime)
Review Comment:
```suggestion
return !truncatedEqualsFunction.apply(startTime, endTime)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
