sveneld opened a new pull request, #3927: URL: https://github.com/apache/thrift/pull/3927
PHP 8.1 is already the minimum supported version, so the PHP < 8.1 branches in `ReflectionHelper` never execute on supported runtimes. Remove those branches and their `setAccessible(true)` calls, simplify the accessors, and update the method descriptions. The existing helper API and PHP minimum remain unchanged. JIRA: [THRIFT-6335](https://issues.apache.org/jira/browse/THRIFT-6335) Validation: - Existing PHP unit suite on PHP 8.4.21: 739 tests, 2,400 assertions, 5 skipped, no failures. - PHP 8.1.34: verified private-property reads/writes and private-method invocation through the helper. - PHP_CodeSniffer for the changed file and `git diff --check`: passed. - Full `make style` could not complete in the local container: `clang-format` is unavailable, and the configured Swift build references a missing `Makefile.am`. - [x] JIRA ticket created and included in the PR title. - [x] Single commit. - [x] No breaking change. Generated-by: OpenAI Codex (GPT-6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
