[
https://issues.apache.org/jira/browse/THRIFT-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-6330.
--------------------------------
Fix Version/s: 0.26.0
Assignee: Jens Geyer
Resolution: Fixed
> Add a GitHub Actions CI job for the JavaScript library
> ------------------------------------------------------
>
> Key: THRIFT-6330
> URL: https://issues.apache.org/jira/browse/THRIFT-6330
> Project: Thrift
> Issue Type: New Feature
> Components: Build Process, JavaScript - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
> Fix For: 0.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{.github/workflows/build.yml}} has no job for {{lib/js}}, so its test suite
> does not run in CI. The {{lib-ts}} job from THRIFT-6319 only covers the
> TypeScript pages.
> On current master, {{make -C lib/js check}} passes in a container: grunt runs
> 9 QUnit targets with 161 tests and 726 assertions, and none fail.
> Two things set this job apart from {{lib-ts}}:
> * {{lib/js/test/build.xml}} stops unless {{lib/java/build/libs}} holds two
> jars, the Java library and its test classes. Gradle builds the test classes
> only as {{testJar}}, so the job builds the library with {{make -C lib/java}}
> and then runs {{gradle testJar}}.
> * The ant half of the check skips its own browser test when phantomjs is
> missing, and still succeeds. The job therefore greps grunt's QUnit totals, as
> {{lib-ts}} does, and it asserts that configure enabled Java and found npm.
> _Drafted with AI assistance (Claude Opus 5); reviewed and posted by Jens
> Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
