Jens-G commented on PR #3920:
URL: https://github.com/apache/thrift/pull/3920#issuecomment-5761516899

   ### Code review
   
   No blocking issues found. Checked for bugs and CLAUDE.md compliance.
   
   One suggestion, below the bar for an issue but verified:
   
   - A small formality for when you next push: the commit message is only the 
subject line. CONTRIBUTING.md asks for a `Client: js,nodejs` line below the 
subject, and AGENTS.md asks for the AI label on the commit as well as on the 
PR, so the `Co-Authored-By: OpenAI Codex <[email protected]>` line from the PR 
description belongs in the commit message too.
   
   
https://github.com/apache/thrift/blob/c2653b305be9087722daef73f29628b7e382f157/CONTRIBUTING.md#L22-L27
   
   
https://github.com/apache/thrift/blob/c2653b305be9087722daef73f29628b7e382f157/AGENTS.md#L60-L65
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to