[
https://issues.apache.org/jira/browse/THRIFT-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-6315.
--------------------------------
Fix Version/s: 0.26.0
Assignee: Jens Geyer
Resolution: Fixed
> Stale msvc2017 paths in the Windows Docker documentation
> --------------------------------------------------------
>
> Key: THRIFT-6315
> URL: https://issues.apache.org/jira/browse/THRIFT-6315
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Minor
> Fix For: 0.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The MSVC container directory was renamed from {{build/docker/msvc2017}} to
> {{build/docker/msvc}}, but the paths that name it were not updated.
> {{doc/ReleaseManagement.md}} has a broken relative link:
> {noformat}
> - Using [Docker for Windows](../build/docker/msvc2017/README.md), follow the
> instructions for building the compiler.
> {noformat}
> and {{build/docker/msvc/README.md}} tells the reader to run commands against
> paths that do not exist, six times:
> {noformat}
> docker pull thrift/thrift-build:msvc2017
> docker build -t thrift/thrift-build:msvc2017 -f
> build\docker\msvc2017\Dockerfile build\
> docker run ... C:\thrift\build\docker\msvc2017\build-compiler.bat
> docker run ... C:\thrift\build\docker\msvc2017\build.bat
> {noformat}
> That README also still describes the image as "just under 30GB", which
> THRIFT-5952 and THRIFT-6237 have since worked on, and points at a
> {{thrift/thrift-build}} Docker Hub tag while the MSVC CI workflow builds and
> caches its image in GHCR instead.
> Noticed while adding a Windows compiler CI job (THRIFT-6310). Not fixed
> there, to keep that change to one subject.
> _Drafted with AI assistance (Claude Opus 5); reviewed and posted by Jens
> Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
