Jens-G commented on PR #3894: URL: https://github.com/apache/thrift/pull/3894#issuecomment-5749601558
Withdrawing this. `WITH_MT` being a no-op is not a bug to fix — it is load-bearing by accident. [`dd8ecde06`](https://github.com/apache/thrift/commit/dd8ecde06) moved the project away from a statically linked Windows compiler, and `doc/ReleaseManagement.md` has said since then that the released compiler "requires Visual C++ Runtime due to ASF regulations". Making `WITH_MT` work again would have turned the release build straight back into the statically linked one that commit removed. What was actually stale is the other half of that commit's cleanup: the document still told the release manager to check for "only kernel32.dll", and `build-compiler.bat` still passed `-DWITH_MT=ON`. That is [#3901](https://github.com/apache/thrift/pull/3901) (THRIFT-6320), which replaces this PR as the base of the stack. Sorry for the noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
