Jens-G opened a new pull request, #3890: URL: https://github.com/apache/thrift/pull/3890
AGENTS.md gains a rule for prose-only changes: a commit that only edits the text of existing documentation files ends its subject line with the skip-ci marker, and the PR title carries it too. No CI job lints documentation, so a full run for a few lines of Markdown ties up build resources for nothing. What the rule settles. Each point was checked against this repository's Actions and AppVeyor history: - **Subject line, not "anywhere".** GitHub Actions accepts the marker anywhere in the message, but AppVeyor reads the first line only. PR #3520 had it on line 2: Actions skipped the PR, and AppVeyor built it anyway. - **What is not prose:** source code (comments included), build, packaging and CI files, tests and test data (`compiler/cpp/test/compiler/DocTest.md` is a golden file), and adding, removing or renaming a file (`EXTRA_DIST`, the `make dist` job, package manifests). - **The reverse case.** GitHub matches the marker even when it is quoted. The squash messages of ab178fbf2 and 3f6d8a57c, both code changes, took in the PR template's checklist line, which quotes the marker, and neither commit got a CI run on master. - **Tool-internal links check.** It runs on `pull_request`, so the marker skips it as well. The rule asks for a manual look at the commit message and the PR text instead. `pypi.yml` no longer triggers on `doc/ReleaseManagement.md`. The workflow builds and checks the Python sdist and wheels and never reads that file. This PR changes a workflow, so it is not prose-only and runs the full CI. Not in this PR, possible follow-ups: - `.github/pull_request_template.md` still says to put the marker "anywhere in the commit message", which is wrong for AppVeyor. Its literal marker is also what leaks into squash messages. - `tool-links.yml` could move to `pull_request_target`, which GitHub does not skip. zizmor flags that trigger, though. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
