Jens-G opened a new pull request, #3889: URL: https://github.com/apache/thrift/pull/3889
[THRIFT-6304](https://issues.apache.org/jira/browse/THRIFT-6304) `lib/delphi/test/serializer/TestSerializer.Data.pas` still tests `cDebugProtoTest_Option_AnsiStr_Binary` in two places. THRIFT-5750 (2adfd14c0, first released in 0.21.0) removed the `ansistr_binary` option, and since then the generator no longer emits this constant. The test was not updated at the time. ```pascal {$IF cDebugProtoTest_Option_AnsiStr_Binary} result.SetBase64('base64'); {$ELSEIF cDebugProtoTest_Option_COM_Types} ``` This PR removes the two `AnsiStr_Binary` branches. The `COM_types` and default branches that remain are unchanged. ### Verification - The `DebugProtoTest.pas` that the test's pre-build step generates (`-gen delphi:com_types`) declares the option constants `Register_Types`, `ConstPrefix`, `Events`, `XmlDoc`, `Async`, `COM_types`, `Old_Names` and `RTTI`, but no `AnsiStr_Binary`. - `git grep -i ansistr_binary` now finds only the THRIFT-5750 entry in `CHANGES.md`. - I did not compile this with Delphi, so how Delphi handled the undeclared identifier is not verified. - An experimental Free Pascal build of the serializer test, with the two branches disabled in the same way, compiled and passed with `com_types`, with its 84 ASSERTs active. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
