[
https://issues.apache.org/jira/browse/THRIFT-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-6284.
--------------------------------
Fix Version/s: 0.25.0
Assignee: Jens Geyer
Resolution: Fixed
> Wire up source and test files that a build list misses (THRIFT-6270 follow-up)
> ------------------------------------------------------------------------------
>
> Key: THRIFT-6284
> URL: https://issues.apache.org/jira/browse/THRIFT-6284
> Project: Thrift
> Issue Type: Task
> Components: Build Process, Test Suite
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Minor
> Fix For: 0.25.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The THRIFT-6270 sweep for source and test files that no build list references
> turned up more than the one PHP case fixed under that ticket. This groups the
> three remaining findings that are clear and testable; the Android Gradle
> build, a fourth finding, is tracked separately as THRIFT-AAAA.
> h2. 1. Lua library modules are never installed
> {{lib/lua/Makefile.am}} installs the four C libraries and {{src/socket.h}},
> but the twelve {{*.lua}} modules appear only in {{EXTRA_DIST}} ({{:63}}).
> {{make install}} therefore delivers the C half of the binding and none of the
> Lua source, so an installed copy is not usable. The cross test does not
> notice because it loads the modules straight from the source tree
> ({{test/tests.json}}). There has been no install rule for the {{.lua}} files
> since the binding was added.
> h2. 2. Python test/test_sasl_transport.py is in no test list
> {{lib/py/test/test_sasl_transport.py}} (added for THRIFT-5926) is named in
> neither {{lib/py/Makefile.am}} nor {{lib/py/CMakeLists.txt}}, so CI never
> runs it. It passes today (7 tests; needs the {{puresasl}} package).
> h2. 3. D thrift/codegen/idlgen.d is in no module list
> {{lib/d/src/thrift/codegen/idlgen.d}} was taken out of the module lists in
> {{lib/d/Makefile.am}} in 2014 (THRIFT-2781, "temporarily ... to be fixed
> later") and never put back, so it is not built, installed or unit-tested by
> the autotools build; the {{dub}} build compiles it. It compiles cleanly
> against the current library (dmd 2.087.0), so the 2014 reason no longer holds.
> h2. Suggested
> Add a {{luadir}} install rule for the {{.lua}} modules; register
> {{test_sasl_transport.py}} in both Python test lists; and return {{idlgen}}
> to the D module lists. Each is verified in the PR.
> _Drafted with AI assistance (Claude Opus 4.8); reviewed and filed by Jens
> Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
