lbarthon commented on PR #3854: URL: https://github.com/apache/thrift/pull/3854#issuecomment-5719870018
@Jens-G Filed THRIFT-6290 and updated the PR title and commit subject to start with it: https://issues.apache.org/jira/browse/THRIFT-6290 On the test note: agreed that the current tests would still pass if skip() went back to read_bytes(), or if the skip_binary forward on Box<P> or TStoredInputProtocol were dropped. Happy to add a transport that records the largest buffer it is asked to fill, and assert that skipping a 1024-byte string never asks for more than 256, if you want that in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
