Jens Geyer created THRIFT-6285:
----------------------------------
Summary: The Android Gradle build references Java source paths
that moved in 2022
Key: THRIFT-6285
URL: https://issues.apache.org/jira/browse/THRIFT-6285
Project: Thrift
Issue Type: Bug
Components: Java - Library, Build Process
Reporter: Jens Geyer
Found by the THRIFT-6270 sweep. {{lib/java/android/build.gradle}} points its
Java source root at {{srcDir '../src'}} and excludes three files by the paths
{{org/apache/thrift/transport/TSasl*Transport.java}}:
{code}
sourceSets.main.java {
srcDir '../src'
exclude 'org/apache/thrift/transport/TSaslClientTransport.java'
exclude 'org/apache/thrift/transport/TSaslServerTransport.java'
exclude 'org/apache/thrift/transport/TSaslTransport.java'
}
{code}
Since THRIFT-5545 (2022) moved the Java sources under {{src/main/java}},
{{../src}} is no longer the source root and the three exclude paths match
nothing (the files are at {{../src/main/java/org/apache/thrift/transport/}}).
{{compileSdkVersion}}/{{buildToolsVersion}} are 23 / 23.0.1 (2015). No CI job
builds this — CMake runs it only under {{if(ANDROID)}} (opt-in), so nothing
catches the drift. The last content change was 2018 ({{7004a61e4}}).
The build is therefore stale and, as it stands, would pull in the test tree and
miss its intended excludes. This is filed for a decision rather than a blind
fix: repair the paths ({{srcDir '../src/main/java'}}, adjust the excludes,
refresh the SDK levels) and give it a smoke build, or retire the unmaintained
Android build together with its {{if(ANDROID)}} CMake branch. It is not fixed
here because there is no Android SDK / CI to verify a change against.
_Drafted with AI assistance (Claude Opus 4.8); reviewed and filed by Jens
Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
