Jens Geyer created THRIFT-6277:
----------------------------------
Summary: CHANGES draft lists tickets that are not fixed in the
release
Key: THRIFT-6277
URL: https://issues.apache.org/jira/browse/THRIFT-6277
Project: Thrift
Issue Type: Bug
Components: Build Process
Reporter: Jens Geyer
Fix For: 0.25.0
{{build/generate-changes.py}} (the "Generate CHANGES draft" workflow) lists
every THRIFT ticket that a commit message in the release range mentions. It
does not check the ticket's Fix Version/s, resolution or status. The 0.25.0
draft therefore listed:
* THRIFT-1337, fixed in 2011 without a Fix Version/s. The THRIFT-6183 commit
mentions it as history.
* 17 more tickets that commit bodies mention: 14 from earlier releases and 3
still open
* THRIFT-5917, resolved as Won't Do
* THRIFT-6108 and THRIFT-6152, which are still open but have partial work
committed
With {{--jira-version}}, the extra lookup of tickets found in git has the same
gap.
A ticket found in git should be listed only if JIRA files it under the release
version, using the same test as the fixVersion query ({{resolution !=
Unresolved AND fixVersion = X AND status != Open}}). A commit whose tickets all
fail that test should be listed as a plain commit or PR link instead.
Tickets resolved without a change (Won't Do, Won't Fix, Not A Problem, Cannot
Reproduce and similar) should stay out of both queries, even when they carry
the fix version.
_Drafted with AI assistance (Claude Opus 5); reviewed and posted by Jens Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)