Jens-G opened a new pull request, #3863: URL: https://github.com/apache/thrift/pull/3863
JIRA: [THRIFT-6265](https://issues.apache.org/jira/browse/THRIFT-6265) Client: py `lib/py/setup.py` added `backports.ssl_match_hostname>=3.5` to the `ssl` extra when `sys.hexversion < 0x03050000`. No build can take that branch: - `pyproject.toml` builds with `setuptools>=69`, which itself needs Python 3.8 or later. - The library supports Python 3.10 to 3.14 (`LANGUAGES.md`, CI matrix). Changes: - `lib/py/setup.py`: the branch is removed. The `ssl` extra stays defined, and stays empty as it has been in every build, so `pip install thrift[ssl]` keeps working without a "does not provide the extra" warning. - `build/appveyor/MSVC-appveyor-full.bat`: the AppVeyor build no longer installs `backports.ssl_match_hostname`. The dead `backports` fallback in `lib/py/src/transport/sslcompat.py`, and the message in `TSSLSocket.py` that names the package, are part of the code THRIFT-6233 changes. This PR leaves both to that ticket. ### Verification No test can tell the two versions apart: the removed branch is unreachable on every interpreter that can run the build. Instead I checked: - The `egg_info` metadata (`Provides-Extra`, `Requires-Dist`, `requires.txt`) is identical before and after, on Python 3.10.12 with the distribution's setuptools and on Python 3.12.14 with setuptools 69+. - `pip install ".[ssl]"` succeeds on 3.12 without an extras warning. - `flake8 lib/py/setup.py` is clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
