[
https://issues.apache.org/jira/browse/THRIFT-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz resolved THRIFT-3269.
------------------------------------------
Resolution: Fixed
Same code path as THRIFT-3204. On master
[processRequests|https://github.com/apache/thrift/blob/master/lib/go/thrift/simple_server.go]
returns transport exceptions, which the accept goroutine logs, and
deliberately continues after an application-level error from {{Process}}, which
is what the Xception cross tests quoted above expect. Resolving as fixed on
master.
_This comment was created with AI assistance._
> error handling issue in SimpleServer
> ------------------------------------
>
> Key: THRIFT-3269
> URL: https://issues.apache.org/jira/browse/THRIFT-3269
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Jens Geyer
> Priority: Major
> Attachments: simple-server.patch
>
>
> There is error handling issue in SimpleServer, which supresses errors instead
> of properly handling them. If the comparingly simple fix is applied, one of
> the Xception test fails all of a sudden.
> {code}
> 2015/07/26 01:52:32 error processing request: TException
> 2015/07/26 01:52:32 error processing request: TException
> --- FAIL: TestTJSONProtocol (0.06s)
> thrifttest_driver.go:224: TestException Xception failed
> 2015/07/26 01:52:32 error processing request: TException
> 2015/07/26 01:52:32 error processing request: TException
> --- FAIL: TestTBinaryProtocol (0.08s)
> thrifttest_driver.go:224: TestException Xception failed
> 2015/07/26 01:52:32 error processing request: TException
> 2015/07/26 01:52:32 error processing request: TException
> --- FAIL: TestTCompactProtocol (0.07s)
> thrifttest_driver.go:224: TestException Xception failed
> FAIL
> FAIL tests 0.398s
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
