Jens-G commented on PR #3826: URL: https://github.com/apache/thrift/pull/3826#issuecomment-5688315711
### Code review No blocking issues found. Checked for bugs and CLAUDE.md compliance. Re-reviewed at 640e71fc3 after the rewrite: the points from the earlier review are addressed. One suggestion, below the bar for an issue but verified: - Line 29 says that building the C++ library as well only takes `boost libevent openssl` and dropping the compiler-only options. On the CMake path that also enables the JavaScript and NodeJS libraries: `BUILD_JAVASCRIPT` and `BUILD_NODEJS` default to ON without any check for Node.js, and both add targets to the default build that run `npm install`. Node.js is not on the page's `brew install` line, so without it `cmake --build cmake-build` fails at the first `npm install`. I reproduced this with these CMake files on Linux, as no Mac was available; the conditions involved do not depend on the platform. Adding `-DWITH_JAVASCRIPT=OFF -DWITH_NODEJS=OFF` to that variant removes both targets. Java and Python are switched on as well when CMake finds their tools. https://github.com/apache/thrift/blob/640e71fc37551735dc63395bf537d77cec4fe51d/doc/install/os_x.md#L28-L30 https://github.com/apache/thrift/blob/640e71fc37551735dc63395bf537d77cec4fe51d/build/cmake/DefineOptions.cmake#L99-L108 https://github.com/apache/thrift/blob/640e71fc37551735dc63395bf537d77cec4fe51d/lib/nodejs/CMakeLists.txt#L34-L40 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
