Jens Geyer created THRIFT-6270:
----------------------------------
Summary: Sweep for source files that no build list mentions
Key: THRIFT-6270
URL: https://issues.apache.org/jira/browse/THRIFT-6270
Project: Thrift
Issue Type: Task
Components: Build Process, Test Suite
Reporter: Jens Geyer
{{lib/d/src/thrift/transport/websocket.d}} was in the tree for five releases
without appearing in any module list in {{lib/d/Makefile.am}}. It was therefore
never built, never tested and never installed, and the omission only surfaced
when someone tried to add a test for it -- the file had to be wired into the
build before it could be compiled at all.
Nothing checks for this. A source file that no build list names produces no
warning from either build system; it simply is not there.
The related case on the *test* side is already filed as THRIFT-6217 (test
programs in an autotools {{check_PROGRAMS}} but absent from
{{CMakeLists.txt}}). This issue is about library sources rather than test
programs, and about a file being in no list at all rather than in one of two.
h2. Suggested
# One pass across the bindings comparing the source files on disk against the
file lists in {{Makefile.am}} / {{CMakeLists.txt}} / the binding's own
manifest, and wire up or delete whatever is unreferenced.
# If that turns up more than the one known case, a small check in the build
worth keeping -- the comparison is mechanical.
_Drafted with AI assistance (Claude Opus 5); reviewed and filed by Jens Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
