Jens Geyer created THRIFT-6272:
----------------------------------
Summary: Node.js: json_protocol.js is not prettier-clean, so any
change to it carries unrelated reformatting
Key: THRIFT-6272
URL: https://issues.apache.org/jira/browse/THRIFT-6272
Project: Thrift
Issue Type: Task
Components: Node.js - Library
Reporter: Jens Geyer
{{npm run prettier}} rewrites {{lib/nodejs/lib/thrift/json_protocol.js}} in
three places that nobody has touched -- around lines 778, 800 and 814 on master.
The practical effect is that a patch to this file either leaves the formatting
inconsistent with the configured style or arrives with a reformatting diff
mixed into it. Neither is good for review, and the choice falls to whoever
happens to touch the file next.
h2. Suggested
One commit that runs the formatter over the file and does nothing else, so
subsequent changes are clean. Worth checking at the same time whether other
files under {{lib/nodejs}} are in the same state, and whether the formatter can
be run in CI -- THRIFT-4551 is the older issue on prettier adoption and is the
natural place for that half.
_Drafted with AI assistance (Claude Opus 5); reviewed and filed by Jens Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
