slachiewicz opened a new pull request, #3853: URL: https://github.com/apache/thrift/pull/3853
JIRA: [THRIFT-6250](https://issues.apache.org/jira/browse/THRIFT-6250) Client: build The MSVC CI job prints about 400 warning lines per run. This takes out the families that have an in-tree fix; the ticket lists what each one is and what is deliberately left for later. What the diff does not show: - The flex skeleton defines `INT8_MIN` and the other limit macros itself when it is not compiled as C99, which a C++ compile never is, and guards each with `#ifndef`. MSVC's `stdint.h`, included later, then redefined them. The `%top` block puts the header first, so the guards skip. winflexbison 2.5.24, which the image installs, is flex 2.6.4 and has the same guards. - `LIBEVENT_ROOT` is passed by build.bat, and CMake 3.27 or later warns three times that `find_package` ignores upper-case `<PACKAGENAME>_ROOT` variables until CMP0144 is NEW. The policy guard follows the CMP0074 one above it. - `FPHSA_NAME_MISMATCHED` is honoured since CMake 3.17 and ignored before, so it stays within the 3.16 minimum. - Not touched: the five `LNK4098` lines come from libevent built `/MT` and need `SET CL=/MD` in `build-libevent.bat`, which rebuilds the Docker image, so that waits for #3844. `protocol.tcc:995` is rewritten by #3594 and #3596. `AI_V4MAPPED` is [THRIFT-6249](https://issues.apache.org/jira/browse/THRIFT-6249). Verified: `cmake -Wdev` configure on macOS with CMake 4.4.3 → no dev warnings; `thrift-compiler` target builds and generates the tutorial; the generated `thriftl.cc` has `#include <stdint.h>` on line 2, ahead of the guards. - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
