kz930 commented on PR #8603: URL: https://github.com/apache/texera/pull/8603#issuecomment-5751802098
Already approved, this is just a note for later. `isSink` uses `toLocaleLowerCase()`, so the `"SINK"` case is locale-dependent: under a tr-TR runtime it lowercases to `"sınk"` and stops matching. Nothing to change in this PR, the only real type containing "sink" is `SimpleSink` and its `i` is already lowercase, but `toLowerCase()` would be the locale-independent choice if that helper is ever touched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
