Copilot commented on code in PR #8590:
URL: https://github.com/apache/texera/pull/8590#discussion_r4044630742
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.spec.ts:
##########
@@ -1503,7 +1503,7 @@ describe("WorkflowFormComponent", () => {
it("offers Connect before a unit is chosen", () => {
build(formViewWorkflow).ngOnInit();
- expect(component.runButtonState).toEqual({ label: "Connect", icon:
"plus-circle", disabled: true });
+ expect(component.runButtonState).toEqual({ label: "Computing Unit",
icon: "plus-circle", disabled: true });
Review Comment:
The enclosing test is still named `offers Connect`, although the expected
label is now `Computing Unit`. Rename it so failures and test reports describe
the current behavior.
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.spec.ts:
##########
@@ -1949,7 +1969,7 @@ describe("PowerButtonComponent", () => {
fixture.detectChanges();
const host = fixture.nativeElement as HTMLElement;
-
expect(host.querySelector(".connect-text")?.textContent).toContain("Connect");
+
expect(host.querySelector(".connect-text")?.textContent).toContain("Computing
Unit");
Review Comment:
The enclosing test name still claims that the trigger renders `Connect`,
which now contradicts its assertion. Rename the test to match the new label.
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.rendered.spec.ts:
##########
@@ -717,7 +717,7 @@ describe("WorkflowFormComponent (rendered template)", () =>
{
expect(el(".runbar .run")).not.toBeNull();
// Default state: no unit chosen, so the button reads Connect and is
disabled.
- expect(el(".runbar .run")?.textContent?.trim()).toContain("Connect");
+ expect(el(".runbar .run")?.textContent?.trim()).toContain("Computing
Unit");
Review Comment:
The nearby comment still says the button reads `Connect`, contradicting this
updated assertion and the rendered behavior. Update the comment so this test
documents the new empty-state label accurately.
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:
##########
@@ -151,32 +150,33 @@
[nzDropdownMenu]="menu"
[nzPlacement]="'bottomRight'"
(nzVisibleChange)="onDropdownVisibilityChange($event)"
- class="computing-units-dropdown-button">
+ class="computing-units-dropdown-button"
+ nz-tooltip
+ [nzTooltipTitle]="computingUnitButtonTooltip">
<div class="button-content">
<texera-user-avatar
*ngIf="selectedComputingUnit"
[avatar]="selectedComputingUnit ? selectedComputingUnit.ownerAvatar :
''"
userColor="grey"
[userName]="selectedComputingUnit ? selectedComputingUnit.ownerName :
''"
- [style.transform]="'scale(0.65)'"
- [style.opacity]="0.7"
- [style.padding-right.px]="2">
+ class="picker-avatar"
+ [style.opacity]="0.7">
</texera-user-avatar>
+ <i
+ nz-icon
+ nzType="deployment-unit"></i>
Review Comment:
This PR changes visible frontend controls, but its description provides no
before/after screenshots or GIF. Add side-by-side visual evidence covering the
picker icon/label/tooltip and enabled empty-state run button, as required for
frontend UI changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
